Submitting for review
Last updated
Last updated
In this guide, we'll walk through submitting for our for review!
After checking in all of your wonderful changes to your strong-component git branch. Push it up to .
against the master branch!
Be descriptive of your changes! The more the better. If possible, include screenshots or GIF demos. Add the that describe your changes.
Since we're adding a brand new component, we'll add the feature label.
Assign or @ at least one code reviewer and one design reviewer. This is required if you're creating a brand new component. If you're unsure who to tag, default to and .
A deploy preview for your Pull Request will automatically be generated. To make it easier for reviewers to QA your updates, provide them with a direct link to your Story either in the Pull Request description or as an additional Github comment.
The Travis build must be green and the coverage score must be 100% before merging into master.
Every pull request automatically fires off a . Once that passes, it'll generate a .
Tag one of the for review.
🚀 All green? All good 😎. Once that gets merged in, we !